Skip to content

Feat cache for the queue #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 26, 2025
Merged

Conversation

conico974
Copy link
Collaborator

@conico974 conico974 commented Mar 24, 2025

Durable object queue should already be able to handle most situation, but there is a case where for a single route, while being stale, you reach the limits of what a single durable object is capable of handling.

For this kind of cases, adding cache in front will help (but in case of error between the worker and the durable object, revalidation may take more time to happen)

There is 1 other upgrade that we could do for this case:

  • Create a proxy durable object in front of the durable queue, it would have some logic to deduplicate in memory and to handle backpressure for the other durable object.

Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: 56dca94

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 24, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@496

commit: 56dca94

@conico974 conico974 marked this pull request as ready for review March 25, 2025 13:56
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this for 1.1.

Could you please work on a doc PR when you have time to describe the Queue Cache and the options so that we can merge at the same time.

@vicb
Copy link
Contributor

vicb commented May 26, 2025

Doc in opennextjs/docs#156

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's add this to the next minor

@conico974 conico974 merged commit 298fd4e into opennextjs:main May 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants